Magellan Linux

Diff of /tags/grubby-8_20/grubby.c

Parent Directory Parent Directory | Revision Log Revision Log | View Patch Patch

revision 1853 by niro, Mon Jul 2 13:12:07 2012 UTC revision 1940 by niro, Mon Oct 1 12:39:50 2012 UTC
# Line 56  int debug = 0; /* Currently just for tem Line 56  int debug = 0; /* Currently just for tem
56  #define NOOP_OPCODE 0x90  #define NOOP_OPCODE 0x90
57  #define JMP_SHORT_OPCODE 0xeb  #define JMP_SHORT_OPCODE 0xeb
58    
59    int isEfi = 0;
60    
61  /* comments get lumped in with indention */  /* comments get lumped in with indention */
62  struct lineElement {  struct lineElement {
63      char * item;      char * item;
# Line 82  enum lineType_e { Line 84  enum lineType_e {
84      LT_MENUENTRY    = 1 << 17,      LT_MENUENTRY    = 1 << 17,
85      LT_ENTRY_END    = 1 << 18,      LT_ENTRY_END    = 1 << 18,
86      LT_SET_VARIABLE = 1 << 19,      LT_SET_VARIABLE = 1 << 19,
87      LT_UNKNOWN      = 1 << 20,      LT_KERNEL_EFI   = 1 << 20,
88        LT_INITRD_EFI   = 1 << 21,
89        LT_UNKNOWN      = 1 << 22,
90  };  };
91    
92  struct singleLine {  struct singleLine {
# Line 205  struct keywordTypes grub2Keywords[] = { Line 209  struct keywordTypes grub2Keywords[] = {
209      { "default",    LT_DEFAULT,     ' ' },      { "default",    LT_DEFAULT,     ' ' },
210      { "fallback",   LT_FALLBACK,    ' ' },      { "fallback",   LT_FALLBACK,    ' ' },
211      { "linux",      LT_KERNEL,      ' ' },      { "linux",      LT_KERNEL,      ' ' },
212        { "linuxefi",   LT_KERNEL_EFI,  ' ' },
213      { "initrd",     LT_INITRD,      ' ', ' ' },      { "initrd",     LT_INITRD,      ' ', ' ' },
214        { "initrdefi",  LT_INITRD_EFI,  ' ', ' ' },
215      { "module",     LT_MBMODULE,    ' ' },      { "module",     LT_MBMODULE,    ' ' },
216      { "kernel",     LT_HYPER,       ' ' },      { "kernel",     LT_HYPER,       ' ' },
217      { NULL, 0, 0 },      { NULL, 0, 0 },
# Line 271  static int isquote(char q) Line 277  static int isquote(char q)
277      return 0;      return 0;
278  }  }
279    
280    static int iskernel(enum lineType_e type) {
281        return (type == LT_KERNEL || type == LT_KERNEL_EFI);
282    }
283    
284    static int isinitrd(enum lineType_e type) {
285        return (type == LT_INITRD || type == LT_INITRD_EFI);
286    }
287    
288  char *grub2ExtractTitle(struct singleLine * line) {  char *grub2ExtractTitle(struct singleLine * line) {
289      char * current;      char * current;
290      char * current_indent;      char * current_indent;
# Line 570  static char * sdupprintf(const char *for Line 584  static char * sdupprintf(const char *for
584      return buf;      return buf;
585  }  }
586    
587    static enum lineType_e preferredLineType(enum lineType_e type,
588     struct configFileInfo *cfi) {
589        if (isEfi && cfi == &grub2ConfigType) {
590     switch (type) {
591     case LT_KERNEL:
592        return LT_KERNEL_EFI;
593     case LT_INITRD:
594        return LT_INITRD_EFI;
595     default:
596        return type;
597     }
598        }
599        return type;
600    }
601    
602  static struct keywordTypes * getKeywordByType(enum lineType_e type,  static struct keywordTypes * getKeywordByType(enum lineType_e type,
603        struct configFileInfo * cfi) {        struct configFileInfo * cfi) {
604      for (struct keywordTypes *kw = cfi->keywords; kw->key; kw++) {      for (struct keywordTypes *kw = cfi->keywords; kw->key; kw++) {
# Line 994  static struct grubConfig * readConfig(co Line 1023  static struct grubConfig * readConfig(co
1023      cfg->flags &= ~GRUB_CONFIG_NO_DEFAULT;      cfg->flags &= ~GRUB_CONFIG_NO_DEFAULT;
1024      defaultLine = line;      defaultLine = line;
1025    
1026          } else if (line->type == LT_KERNEL) {          } else if (iskernel(line->type)) {
1027      /* if by some freak chance this is multiboot and the "module"      /* if by some freak chance this is multiboot and the "module"
1028       * lines came earlier in the template, make sure to use LT_HYPER       * lines came earlier in the template, make sure to use LT_HYPER
1029       * instead of LT_KERNEL now       * instead of LT_KERNEL now
# Line 1011  static struct grubConfig * readConfig(co Line 1040  static struct grubConfig * readConfig(co
1040      for (struct singleLine *l = entry->lines; l; l = l->next) {      for (struct singleLine *l = entry->lines; l; l = l->next) {
1041   if (l->type == LT_HYPER)   if (l->type == LT_HYPER)
1042      break;      break;
1043   else if (l->type == LT_KERNEL) {   else if (iskernel(l->type)) {
1044      l->type = LT_HYPER;      l->type = LT_HYPER;
1045      break;      break;
1046   }   }
# Line 1310  static int writeConfig(struct grubConfig Line 1339  static int writeConfig(struct grubConfig
1339    
1340      /* most likely the symlink is relative, so change our      /* most likely the symlink is relative, so change our
1341         directory to the dir of the symlink */         directory to the dir of the symlink */
1342              rc = chdir(dirname(outName));      char *dir = strdupa(outName);
1343        rc = chdir(dirname(dir));
1344      do {      do {
1345   buf = alloca(len + 1);   buf = alloca(len + 1);
1346   rc = readlink(basename(outName), buf, len);   rc = readlink(basename(outName), buf, len);
# Line 1564  int suitableImage(struct singleEntry * e Line 1594  int suitableImage(struct singleEntry * e
1594   return 0;   return 0;
1595      }      }
1596    
1597      line = getLineByType(LT_KERNEL|LT_HYPER, entry->lines);      line = getLineByType(LT_KERNEL|LT_HYPER|LT_KERNEL_EFI, entry->lines);
1598      if (!line) {      if (!line) {
1599   notSuitablePrintf(entry, "no line found\n");   notSuitablePrintf(entry, "no line found\n");
1600   return 0;   return 0;
# Line 1694  struct singleEntry * findEntryByPath(str Line 1724  struct singleEntry * findEntryByPath(str
1724   entry = findEntryByIndex(config, indexVars[i]);   entry = findEntryByIndex(config, indexVars[i]);
1725   if (!entry) return NULL;   if (!entry) return NULL;
1726    
1727   line = getLineByType(LT_KERNEL|LT_HYPER, entry->lines);   line = getLineByType(LT_KERNEL|LT_HYPER|LT_KERNEL_EFI, entry->lines);
1728   if (!line) return NULL;   if (!line) return NULL;
1729    
1730   if (index) *index = indexVars[i];   if (index) *index = indexVars[i];
# Line 1743  struct singleEntry * findEntryByPath(str Line 1773  struct singleEntry * findEntryByPath(str
1773    
1774      /* check all the lines matching checkType */      /* check all the lines matching checkType */
1775      for (line = entry->lines; line; line = line->next) {      for (line = entry->lines; line; line = line->next) {
1776   line = getLineByType(entry->multiboot && checkType == LT_KERNEL ?   line = getLineByType(entry->multiboot && checkType == LT_KERNEL
1777       LT_KERNEL|LT_MBMODULE|LT_HYPER :   ? LT_KERNEL|LT_KERNEL_EFI|LT_MBMODULE|LT_HYPER
1778       checkType, line);   : checkType, line);
1779   if (!line) break;  /* not found in this entry */   if (!line) break;  /* not found in this entry */
1780    
1781   if (line && line->type != LT_MENUENTRY &&   if (line && line->type != LT_MENUENTRY &&
# Line 1765  struct singleEntry * findEntryByPath(str Line 1795  struct singleEntry * findEntryByPath(str
1795       * non-Linux boot entries (could find netbsd etc, though, which is       * non-Linux boot entries (could find netbsd etc, though, which is
1796       * unfortunate)       * unfortunate)
1797       */       */
1798      if (line && getLineByType(LT_KERNEL|LT_HYPER, entry->lines))      if (line && getLineByType(LT_KERNEL|LT_HYPER|LT_KERNEL_EFI, entry->lines))
1799   break; /* found 'im! */   break; /* found 'im! */
1800   }   }
1801    
# Line 1867  void markRemovedImage(struct grubConfig Line 1897  void markRemovedImage(struct grubConfig
1897    
1898  void setDefaultImage(struct grubConfig * config, int hasNew,  void setDefaultImage(struct grubConfig * config, int hasNew,
1899       const char * defaultKernelPath, int newIsDefault,       const char * defaultKernelPath, int newIsDefault,
1900       const char * prefix, int flags) {       const char * prefix, int flags, int index) {
1901      struct singleEntry * entry, * entry2, * newDefault;      struct singleEntry * entry, * entry2, * newDefault;
1902      int i, j;      int i, j;
1903    
1904      if (newIsDefault) {      if (newIsDefault) {
1905   config->defaultImage = 0;   config->defaultImage = 0;
1906   return;   return;
1907        } else if ((index >= 0) && config->cfi->defaultIsIndex) {
1908     if (findEntryByIndex(config, index))
1909        config->defaultImage = index;
1910     else
1911        config->defaultImage = -1;
1912     return;
1913      } else if (defaultKernelPath) {      } else if (defaultKernelPath) {
1914   i = 0;   i = 0;
1915   if (findEntryByPath(config, defaultKernelPath, prefix, &i)) {   if (findEntryByPath(config, defaultKernelPath, prefix, &i)) {
# Line 1948  void displayEntry(struct singleEntry * e Line 1984  void displayEntry(struct singleEntry * e
1984    
1985      printf("index=%d\n", index);      printf("index=%d\n", index);
1986    
1987      line = getLineByType(LT_KERNEL|LT_HYPER, entry->lines);      line = getLineByType(LT_KERNEL|LT_HYPER|LT_KERNEL_EFI, entry->lines);
1988      if (!line) {      if (!line) {
1989          printf("non linux entry\n");          printf("non linux entry\n");
1990          return;          return;
# Line 2013  void displayEntry(struct singleEntry * e Line 2049  void displayEntry(struct singleEntry * e
2049   printf("root=%s\n", s);   printf("root=%s\n", s);
2050      }      }
2051    
2052      line = getLineByType(LT_INITRD, entry->lines);      line = getLineByType(LT_INITRD|LT_INITRD_EFI, entry->lines);
2053    
2054      if (line && line->numElements >= 2) {      if (line && line->numElements >= 2) {
2055   if (!strncmp(prefix, line->elements[1].item, strlen(prefix)))   if (!strncmp(prefix, line->elements[1].item, strlen(prefix)))
# Line 2414  struct singleLine * addLineTmpl(struct s Line 2450  struct singleLine * addLineTmpl(struct s
2450  {  {
2451      struct singleLine * newLine = lineDup(tmplLine);      struct singleLine * newLine = lineDup(tmplLine);
2452    
2453        if (isEfi && cfi == &grub2ConfigType) {
2454     enum lineType_e old = newLine->type;
2455     newLine->type = preferredLineType(newLine->type, cfi);
2456     if (old != newLine->type)
2457        newLine->elements[0].item = getKeyByType(newLine->type, cfi);
2458        }
2459    
2460      if (val) {      if (val) {
2461   /* override the inherited value with our own.   /* override the inherited value with our own.
2462   * This is a little weak because it only applies to elements[1]   * This is a little weak because it only applies to elements[1]
# Line 2423  struct singleLine * addLineTmpl(struct s Line 2466  struct singleLine * addLineTmpl(struct s
2466   insertElement(newLine, val, 1, cfi);   insertElement(newLine, val, 1, cfi);
2467    
2468   /* but try to keep the rootspec from the template... sigh */   /* but try to keep the rootspec from the template... sigh */
2469   if (tmplLine->type & (LT_HYPER|LT_KERNEL|LT_MBMODULE|LT_INITRD)) {   if (tmplLine->type & (LT_HYPER|LT_KERNEL|LT_MBMODULE|LT_INITRD|LT_KERNEL_EFI|LT_INITRD_EFI)) {
2470      char * rootspec = getRootSpecifier(tmplLine->elements[1].item);      char * rootspec = getRootSpecifier(tmplLine->elements[1].item);
2471      if (rootspec != NULL) {      if (rootspec != NULL) {
2472   free(newLine->elements[1].item);   free(newLine->elements[1].item);
# Line 2460  struct singleLine *  addLine(struct sing Line 2503  struct singleLine *  addLine(struct sing
2503      /* NB: This function shouldn't allocate items on the heap, rather on the      /* NB: This function shouldn't allocate items on the heap, rather on the
2504       * stack since it calls addLineTmpl which will make copies.       * stack since it calls addLineTmpl which will make copies.
2505       */       */
   
2506      if (type == LT_TITLE && cfi->titleBracketed) {      if (type == LT_TITLE && cfi->titleBracketed) {
2507   /* we're doing a bracketed title (zipl) */   /* we're doing a bracketed title (zipl) */
2508   tmpl.type = type;   tmpl.type = type;
# Line 2794  int updateActualImage(struct grubConfig Line 2836  int updateActualImage(struct grubConfig
2836      firstElement = 2;      firstElement = 2;
2837    
2838   } else {   } else {
2839      line = getLineByType(LT_KERNEL|LT_MBMODULE, entry->lines);      line = getLineByType(LT_KERNEL|LT_MBMODULE|LT_KERNEL_EFI, entry->lines);
2840      if (!line) {      if (!line) {
2841   /* no LT_KERNEL or LT_MBMODULE in this entry? */   /* no LT_KERNEL or LT_MBMODULE in this entry? */
2842   continue;   continue;
# Line 2959  int updateInitrd(struct grubConfig * cfg Line 3001  int updateInitrd(struct grubConfig * cfg
3001      if (!image) return 0;      if (!image) return 0;
3002    
3003      for (; (entry = findEntryByPath(cfg, image, prefix, &index)); index++) {      for (; (entry = findEntryByPath(cfg, image, prefix, &index)); index++) {
3004          kernelLine = getLineByType(LT_KERNEL, entry->lines);          kernelLine = getLineByType(LT_KERNEL|LT_KERNEL_EFI, entry->lines);
3005          if (!kernelLine) continue;          if (!kernelLine) continue;
3006    
3007          line = getLineByType(LT_INITRD, entry->lines);          line = getLineByType(LT_INITRD|LT_INITRD_EFI, entry->lines);
3008          if (line)          if (line)
3009              removeLine(entry, line);              removeLine(entry, line);
3010          if (prefix) {          if (prefix) {
# Line 2973  int updateInitrd(struct grubConfig * cfg Line 3015  int updateInitrd(struct grubConfig * cfg
3015   endLine = getLineByType(LT_ENTRY_END, entry->lines);   endLine = getLineByType(LT_ENTRY_END, entry->lines);
3016   if (endLine)   if (endLine)
3017      removeLine(entry, endLine);      removeLine(entry, endLine);
3018          line = addLine(entry, cfg->cfi, LT_INITRD, kernelLine->indent, initrd);          line = addLine(entry, cfg->cfi, preferredLineType(LT_INITRD, cfg->cfi),
3019     kernelLine->indent, initrd);
3020          if (!line)          if (!line)
3021      return 1;      return 1;
3022   if (endLine) {   if (endLine) {
# Line 3263  int checkForYaboot(struct grubConfig * c Line 3306  int checkForYaboot(struct grubConfig * c
3306      return 1;      return 1;
3307  }  }
3308    
3309    int checkForElilo(struct grubConfig * config) {
3310        if (!access("/etc/elilo.conf", R_OK))
3311     return 2;
3312    
3313        return 1;
3314    }
3315    
3316  static char * getRootSpecifier(char * str) {  static char * getRootSpecifier(char * str) {
3317      char * idx, * rootspec = NULL;      char * idx, * rootspec = NULL;
3318    
# Line 3379  int addNewKernel(struct grubConfig * con Line 3429  int addNewKernel(struct grubConfig * con
3429      while (*chptr && isspace(*chptr)) chptr++;      while (*chptr && isspace(*chptr)) chptr++;
3430      if (*chptr == '#') continue;      if (*chptr == '#') continue;
3431    
3432      if (tmplLine->type == LT_KERNEL &&      if (iskernel(tmplLine->type) && tmplLine->numElements >= 2) {
     tmplLine->numElements >= 2) {  
3433   if (!template->multiboot && (needs & NEED_MB)) {   if (!template->multiboot && (needs & NEED_MB)) {
3434      /* it's not a multiboot template and this is the kernel      /* it's not a multiboot template and this is the kernel
3435       * line.  Try to be intelligent about inserting the       * line.  Try to be intelligent about inserting the
# Line 3457  int addNewKernel(struct grubConfig * con Line 3506  int addNewKernel(struct grubConfig * con
3506      /* template is multi but new is not,      /* template is multi but new is not,
3507       * insert the kernel in the first module slot       * insert the kernel in the first module slot
3508       */       */
3509      tmplLine->type = LT_KERNEL;      tmplLine->type = preferredLineType(LT_KERNEL, config->cfi);
3510      free(tmplLine->elements[0].item);      free(tmplLine->elements[0].item);
3511      tmplLine->elements[0].item =      tmplLine->elements[0].item =
3512   strdup(getKeywordByType(LT_KERNEL, config->cfi)->key);   strdup(getKeywordByType(tmplLine->type,
3513     config->cfi)->key);
3514      newLine = addLineTmpl(new, tmplLine, newLine,      newLine = addLineTmpl(new, tmplLine, newLine,
3515    newKernelPath + strlen(prefix), config->cfi);    newKernelPath + strlen(prefix),
3516      config->cfi);
3517      needs &= ~NEED_KERNEL;      needs &= ~NEED_KERNEL;
3518   } else if (needs & NEED_INITRD) {   } else if (needs & NEED_INITRD) {
3519      char *initrdVal;      char *initrdVal;
3520      /* template is multi but new is not,      /* template is multi but new is not,
3521       * insert the initrd in the second module slot       * insert the initrd in the second module slot
3522       */       */
3523      tmplLine->type = LT_INITRD;      tmplLine->type = preferredLineType(LT_INITRD, config->cfi);
3524      free(tmplLine->elements[0].item);      free(tmplLine->elements[0].item);
3525      tmplLine->elements[0].item =      tmplLine->elements[0].item =
3526   strdup(getKeywordByType(LT_INITRD, config->cfi)->key);   strdup(getKeywordByType(tmplLine->type,
3527     config->cfi)->key);
3528      initrdVal = getInitrdVal(config, prefix, tmplLine, newKernelInitrd, extraInitrds, extraInitrdCount);      initrdVal = getInitrdVal(config, prefix, tmplLine, newKernelInitrd, extraInitrds, extraInitrdCount);
3529      newLine = addLineTmpl(new, tmplLine, newLine, initrdVal, config->cfi);      newLine = addLineTmpl(new, tmplLine, newLine, initrdVal, config->cfi);
3530      free(initrdVal);      free(initrdVal);
3531      needs &= ~NEED_INITRD;      needs &= ~NEED_INITRD;
3532   }   }
3533    
3534      } else if (tmplLine->type == LT_INITRD &&      } else if (isinitrd(tmplLine->type) && tmplLine->numElements >= 2) {
        tmplLine->numElements >= 2) {  
3535   if (needs & NEED_INITRD &&   if (needs & NEED_INITRD &&
3536      new->multiboot && !template->multiboot &&      new->multiboot && !template->multiboot &&
3537      config->cfi->mbInitRdIsModule) {      config->cfi->mbInitRdIsModule) {
# Line 3534  int addNewKernel(struct grubConfig * con Line 3585  int addNewKernel(struct grubConfig * con
3585      static const char *prefix = "'Loading ";      static const char *prefix = "'Loading ";
3586      if (tmplLine->numElements > 1 &&      if (tmplLine->numElements > 1 &&
3587      strstr(tmplLine->elements[1].item, prefix) &&      strstr(tmplLine->elements[1].item, prefix) &&
3588      masterLine->next && masterLine->next->type == LT_KERNEL) {      masterLine->next &&
3589        iskernel(masterLine->next->type)) {
3590   char *newTitle = malloc(strlen(prefix) +   char *newTitle = malloc(strlen(prefix) +
3591   strlen(newKernelTitle) + 2);   strlen(newKernelTitle) + 2);
3592    
# Line 3561  int addNewKernel(struct grubConfig * con Line 3613  int addNewKernel(struct grubConfig * con
3613   */   */
3614   switch (config->cfi->entryStart) {   switch (config->cfi->entryStart) {
3615      case LT_KERNEL:      case LT_KERNEL:
3616        case LT_KERNEL_EFI:
3617   if (new->multiboot && config->cfi->mbHyperFirst) {   if (new->multiboot && config->cfi->mbHyperFirst) {
3618      /* fall through to LT_HYPER */      /* fall through to LT_HYPER */
3619   } else {   } else {
3620      newLine = addLine(new, config->cfi, LT_KERNEL,      newLine = addLine(new, config->cfi,
3621              preferredLineType(LT_KERNEL, config->cfi),
3622        config->primaryIndent,        config->primaryIndent,
3623        newKernelPath + strlen(prefix));        newKernelPath + strlen(prefix));
3624      needs &= ~NEED_KERNEL;      needs &= ~NEED_KERNEL;
# Line 3640  int addNewKernel(struct grubConfig * con Line 3694  int addNewKernel(struct grubConfig * con
3694      if (needs & NEED_KERNEL) {      if (needs & NEED_KERNEL) {
3695   newLine = addLine(new, config->cfi,   newLine = addLine(new, config->cfi,
3696    (new->multiboot && getKeywordByType(LT_MBMODULE,    (new->multiboot && getKeywordByType(LT_MBMODULE,
3697        config->cfi)) ?        config->cfi))
3698    LT_MBMODULE : LT_KERNEL,     ? LT_MBMODULE
3699     : preferredLineType(LT_KERNEL, config->cfi),
3700    config->secondaryIndent,    config->secondaryIndent,
3701    newKernelPath + strlen(prefix));    newKernelPath + strlen(prefix));
3702   needs &= ~NEED_KERNEL;   needs &= ~NEED_KERNEL;
# Line 3657  int addNewKernel(struct grubConfig * con Line 3712  int addNewKernel(struct grubConfig * con
3712   initrdVal = getInitrdVal(config, prefix, NULL, newKernelInitrd, extraInitrds, extraInitrdCount);   initrdVal = getInitrdVal(config, prefix, NULL, newKernelInitrd, extraInitrds, extraInitrdCount);
3713   newLine = addLine(new, config->cfi,   newLine = addLine(new, config->cfi,
3714    (new->multiboot && getKeywordByType(LT_MBMODULE,    (new->multiboot && getKeywordByType(LT_MBMODULE,
3715        config->cfi)) ?        config->cfi))
3716    LT_MBMODULE : LT_INITRD,     ? LT_MBMODULE
3717       : preferredLineType(LT_INITRD, config->cfi),
3718    config->secondaryIndent,    config->secondaryIndent,
3719    initrdVal);    initrdVal);
3720   free(initrdVal);   free(initrdVal);
# Line 3733  int main(int argc, const char ** argv) { Line 3789  int main(int argc, const char ** argv) {
3789      int displayDefault = 0;      int displayDefault = 0;
3790      int displayDefaultIndex = 0;      int displayDefaultIndex = 0;
3791      int displayDefaultTitle = 0;      int displayDefaultTitle = 0;
3792        int defaultIndex = -1;
3793      struct poptOption options[] = {      struct poptOption options[] = {
3794   { "add-kernel", 0, POPT_ARG_STRING, &newKernelPath, 0,   { "add-kernel", 0, POPT_ARG_STRING, &newKernelPath, 0,
3795      _("add an entry for the specified kernel"), _("kernel-path") },      _("add an entry for the specified kernel"), _("kernel-path") },
# Line 3750  int main(int argc, const char ** argv) { Line 3807  int main(int argc, const char ** argv) {
3807   { "boot-filesystem", 0, POPT_ARG_STRING, &bootPrefix, 0,   { "boot-filesystem", 0, POPT_ARG_STRING, &bootPrefix, 0,
3808      _("filestystem which contains /boot directory (for testing only)"),      _("filestystem which contains /boot directory (for testing only)"),
3809      _("bootfs") },      _("bootfs") },
3810  #if defined(__i386__) || defined(__x86_64__) || defined (__powerpc64__)  #if defined(__i386__) || defined(__x86_64__) || defined (__powerpc64__) || defined (__ia64__)
3811   { "bootloader-probe", 0, POPT_ARG_NONE, &bootloaderProbe, 0,   { "bootloader-probe", 0, POPT_ARG_NONE, &bootloaderProbe, 0,
3812      _("check which bootloader is installed on boot sector") },      _("check which bootloader is installed on boot sector") },
3813  #endif  #endif
# Line 3773  int main(int argc, const char ** argv) { Line 3830  int main(int argc, const char ** argv) {
3830      _("display the title of the default kernel") },      _("display the title of the default kernel") },
3831   { "elilo", 0, POPT_ARG_NONE, &configureELilo, 0,   { "elilo", 0, POPT_ARG_NONE, &configureELilo, 0,
3832      _("configure elilo bootloader") },      _("configure elilo bootloader") },
3833     { "efi", 0, POPT_ARG_NONE, &isEfi, 0,
3834        _("force grub2 stanzas to use efi") },
3835   { "extlinux", 0, POPT_ARG_NONE, &configureExtLinux, 0,   { "extlinux", 0, POPT_ARG_NONE, &configureExtLinux, 0,
3836      _("configure extlinux bootloader (from syslinux)") },      _("configure extlinux bootloader (from syslinux)") },
3837   { "grub", 0, POPT_ARG_NONE, &configureGrub, 0,   { "grub", 0, POPT_ARG_NONE, &configureGrub, 0,
# Line 3805  int main(int argc, const char ** argv) { Line 3864  int main(int argc, const char ** argv) {
3864   { "set-default", 0, POPT_ARG_STRING, &defaultKernel, 0,   { "set-default", 0, POPT_ARG_STRING, &defaultKernel, 0,
3865      _("make the first entry referencing the specified kernel "      _("make the first entry referencing the specified kernel "
3866        "the default"), _("kernel-path") },        "the default"), _("kernel-path") },
3867     { "set-default-index", 0, POPT_ARG_INT, &defaultIndex, 0,
3868        _("make the given entry index the default entry"),
3869        _("entry-index") },
3870   { "silo", 0, POPT_ARG_NONE, &configureSilo, 0,   { "silo", 0, POPT_ARG_NONE, &configureSilo, 0,
3871      _("configure silo bootloader") },      _("configure silo bootloader") },
3872   { "title", 0, POPT_ARG_STRING, &newKernelTitle, 0,   { "title", 0, POPT_ARG_STRING, &newKernelTitle, 0,
# Line 3913  int main(int argc, const char ** argv) { Line 3975  int main(int argc, const char ** argv) {
3975      }      }
3976    
3977      if (bootloaderProbe && (displayDefault || kernelInfo || newKernelVersion ||      if (bootloaderProbe && (displayDefault || kernelInfo || newKernelVersion ||
3978    newKernelPath || removeKernelPath || makeDefault ||      newKernelPath || removeKernelPath || makeDefault ||
3979    defaultKernel || displayDefaultIndex || displayDefaultTitle)) {      defaultKernel || displayDefaultIndex || displayDefaultTitle ||
3980        (defaultIndex >= 0))) {
3981   fprintf(stderr, _("grubby: --bootloader-probe may not be used with "   fprintf(stderr, _("grubby: --bootloader-probe may not be used with "
3982    "specified option"));    "specified option"));
3983   return 1;   return 1;
# Line 3956  int main(int argc, const char ** argv) { Line 4019  int main(int argc, const char ** argv) {
4019   makeDefault = 1;   makeDefault = 1;
4020   defaultKernel = NULL;   defaultKernel = NULL;
4021      }      }
4022        else if (defaultKernel && (defaultIndex >= 0)) {
4023     fprintf(stderr, _("grubby: --set-default and --set-default-index "
4024      "may not be used together\n"));
4025     return 1;
4026        }
4027    
4028      if (grubConfig && !strcmp(grubConfig, "-") && !outputFile) {      if (grubConfig && !strcmp(grubConfig, "-") && !outputFile) {
4029   fprintf(stderr, _("grubby: output file must be specified if stdin "   fprintf(stderr, _("grubby: output file must be specified if stdin "
# Line 3964  int main(int argc, const char ** argv) { Line 4032  int main(int argc, const char ** argv) {
4032      }      }
4033    
4034      if (!removeKernelPath && !newKernelPath && !displayDefault && !defaultKernel      if (!removeKernelPath && !newKernelPath && !displayDefault && !defaultKernel
4035   && !kernelInfo && !bootloaderProbe && !updateKernelPath   && !kernelInfo && !bootloaderProbe && !updateKernelPath
4036          && !removeMBKernel && !displayDefaultIndex && !displayDefaultTitle) {   && !removeMBKernel && !displayDefaultIndex && !displayDefaultTitle
4037     && (defaultIndex == -1)) {
4038   fprintf(stderr, _("grubby: no action specified\n"));   fprintf(stderr, _("grubby: no action specified\n"));
4039   return 1;   return 1;
4040      }      }
# Line 3992  int main(int argc, const char ** argv) { Line 4061  int main(int argc, const char ** argv) {
4061      }      }
4062    
4063      if (bootloaderProbe) {      if (bootloaderProbe) {
4064   int lrc = 0, grc = 0, gr2c = 0, erc = 0, yrc = 0;   int lrc = 0, grc = 0, gr2c = 0, extrc = 0, yrc = 0, erc = 0;
4065   struct grubConfig * lconfig, * gconfig, * yconfig;   struct grubConfig * lconfig, * gconfig, * yconfig, * econfig;
4066    
4067   const char *grub2config = grub2FindConfig(&grub2ConfigType);   const char *grub2config = grub2FindConfig(&grub2ConfigType);
4068   if (grub2config) {   if (grub2config) {
# Line 4021  int main(int argc, const char ** argv) { Line 4090  int main(int argc, const char ** argv) {
4090   lrc = checkForLilo(lconfig);   lrc = checkForLilo(lconfig);
4091   }   }
4092    
4093     if (!access(eliloConfigType.defaultConfig, F_OK)) {
4094        econfig = readConfig(eliloConfigType.defaultConfig,
4095     &eliloConfigType);
4096        if (!econfig)
4097     erc = 1;
4098        else
4099     erc = checkForElilo(econfig);
4100     }
4101    
4102   if (!access(extlinuxConfigType.defaultConfig, F_OK)) {   if (!access(extlinuxConfigType.defaultConfig, F_OK)) {
4103      lconfig = readConfig(extlinuxConfigType.defaultConfig, &extlinuxConfigType);      lconfig = readConfig(extlinuxConfigType.defaultConfig, &extlinuxConfigType);
4104      if (!lconfig)      if (!lconfig)
4105   erc = 1;   extrc = 1;
4106      else      else
4107   erc = checkForExtLinux(lconfig);   extrc = checkForExtLinux(lconfig);
4108   }   }
4109    
4110    
# Line 4036  int main(int argc, const char ** argv) { Line 4114  int main(int argc, const char ** argv) {
4114      if (!yconfig)      if (!yconfig)
4115   yrc = 1;   yrc = 1;
4116      else      else
4117        yrc = checkForYaboot(lconfig);   yrc = checkForYaboot(yconfig);
4118   }   }
4119    
4120   if (lrc == 1 || grc == 1 || gr2c == 1 || yrc == 1) return 1;   if (lrc == 1 || grc == 1 || gr2c == 1 || extrc == 1 || yrc == 1 ||
4121     erc == 1)
4122        return 1;
4123    
4124   if (lrc == 2) printf("lilo\n");   if (lrc == 2) printf("lilo\n");
4125   if (gr2c == 2) printf("grub2\n");   if (gr2c == 2) printf("grub2\n");
4126   if (grc == 2) printf("grub\n");   if (grc == 2) printf("grub\n");
4127   if (erc == 2) printf("extlinux\n");   if (extrc == 2) printf("extlinux\n");
4128   if (yrc == 2) printf("yaboot\n");   if (yrc == 2) printf("yaboot\n");
4129     if (erc == 2) printf("elilo\n");
4130    
4131   return 0;   return 0;
4132      }      }
# Line 4063  int main(int argc, const char ** argv) { Line 4144  int main(int argc, const char ** argv) {
4144   if (!entry) return 0;   if (!entry) return 0;
4145   if (!suitableImage(entry, bootPrefix, 0, flags)) return 0;   if (!suitableImage(entry, bootPrefix, 0, flags)) return 0;
4146    
4147   line = getLineByType(LT_KERNEL|LT_HYPER, entry->lines);   line = getLineByType(LT_KERNEL|LT_HYPER|LT_KERNEL_EFI, entry->lines);
4148   if (!line) return 0;   if (!line) return 0;
4149    
4150          rootspec = getRootSpecifier(line->elements[1].item);          rootspec = getRootSpecifier(line->elements[1].item);
# Line 4112  int main(int argc, const char ** argv) { Line 4193  int main(int argc, const char ** argv) {
4193      markRemovedImage(config, removeKernelPath, bootPrefix);      markRemovedImage(config, removeKernelPath, bootPrefix);
4194      markRemovedImage(config, removeMBKernel, bootPrefix);      markRemovedImage(config, removeMBKernel, bootPrefix);
4195      setDefaultImage(config, newKernelPath != NULL, defaultKernel, makeDefault,      setDefaultImage(config, newKernelPath != NULL, defaultKernel, makeDefault,
4196      bootPrefix, flags);      bootPrefix, flags, defaultIndex);
4197      setFallbackImage(config, newKernelPath != NULL);      setFallbackImage(config, newKernelPath != NULL);
4198      if (updateImage(config, updateKernelPath, bootPrefix, newKernelArgs,      if (updateImage(config, updateKernelPath, bootPrefix, newKernelArgs,
4199                      removeArgs, newMBKernelArgs, removeMBKernelArgs)) return 1;                      removeArgs, newMBKernelArgs, removeMBKernelArgs)) return 1;

Legend:
Removed from v.1853  
changed lines
  Added in v.1940