--- trunk/installer-simple/bin/installer.sh.in	2014/01/03 15:01:06	2344
+++ trunk/installer-simple/bin/installer.sh.in	2014/01/07 13:33:46	2412
@@ -16,13 +16,26 @@
 # -> now in images.conf
 CURRENTLINE=0
 
-# configuration
-if [ -e %SYSCONFDIR%/installer.conf ]
-then
-	source %SYSCONFDIR%/installer.conf
-else
-	die "/etc/installer.conf not found"
-fi
+die()
+{
+	echo "Error: $@"
+	exit 1
+}
+
+# load common includes
+for inc in %SYSCONFDIR%/installer.conf \
+	${INSTALLER_LIBDIR}/functions/common.sh \
+	${INSTALLER_LIBDIR}/functions/common-dialogs.sh \
+	${INSTALLER_LIBDIR}/functions/hwdetection.sh \
+	${INSTALLER_LIBDIR}/functions/installer-dialogs.sh
+do
+	if [ -e ${inc} ]
+	then
+		source "${inc}"
+	else
+		die "'${inc}' not found"
+	fi
+done
 
 # TOTALLINES=linecount of ${CDIMAGENAME}-tarball -1 !
 # -> now in images.conf
@@ -39,40 +52,35 @@
 	die "/mnt/cdrom/system/images.conf not found"
 fi
 
-# includes
-source ${INSTALLER_LIBDIR}/functions/hwdetection.sh
-
 ### System/Config Version
 VERSION="%VERSIONTAG%"
 TITLE="${DEFAULT_TITLE} - ${VERSION}"
 
+# some sane defaults
 CDROOT="${DEFAULT_CDROOT}"
 INSTALLROOT="${DEFAULT_INSTALLROOT}"
-
-# standard kernel opts
-KERNELOPTS="quiet video=1024x768"
-
-# grub options
+KERNELPKG="${DEFAULT_KERNELPKG}"
+KERNELOPTS="${DEFAULT_KERNELOPTS}"
 GRUBLEGACYOPTS=""
 GRUB2OPTS=""
-
-# fdisk options
 FDISKPARTIONBELOW256MB=0
-
-# default specialdevices
 SPECIALDEVICE=""
-FORMFACTOR="desktop"
-
-# target filesystem
+FORMFACTOR="${DEFAULT_FORMFACTOR}"
 FORMAT_FILESYSTEM="${DEFAULT_FILESYSTEM}"
 
 #################################################
 #		  DIALOG BOXEN			#
 #################################################
 
-die()
+trap_exit()
 {
-	echo "Error: $@"
+	is_mounted --location "${INSTALLROOT}/dev" && umount ${INSTALLROOT}/dev
+	is_mounted --location "${INSTALLROOT}/proc" && umount ${INSTALLROOT}/proc
+	is_mounted --location "${INSTALLROOT}/sys" && umount ${INSTALLROOT}/sys
+	is_mounted --location "${INSTALLROOT}/boot" && umount ${INSTALLROOT}/boot
+	is_mounted --location "${INSTALLROOT}" && umount ${INSTALLROOT}
+
+	echo $"Installation aborted."
 	exit 1
 }
 
@@ -86,70 +94,40 @@
 
 dialog_warning()
 {
-	dialog \
-	--backtitle "${TITLE}" \
-	--colors \
-	--defaultno \
-	--yesno "\Z1 !!! Achtung !!! \Zn\n\n\
-	Diese Festplatte wird unwiederruflich geloescht werden.\n\n\
-		Soll ich wirklich fortfahren ?" 10 70
-	RES=$?
-	if [[ ${RES} -eq 1 ]]
+	local retval
+
+	yesnobox $"\Z1 !!! Warning !!! \Zn\n\n\This harddrive will be irreversibly erased.\n\n\Do you want to continue ?"
+	retval=$?
+	if [[ ${retval} -eq 1 ]]
 	then
 		clear
-		echo "Der Vorgang wurde abgebrochen."
+		echo $"The process was aborted."
 		exit 1
 	fi
 }
 
 dialog_setup_hdd_info()
 {
-	local SHDD="$(echo ${HDD} | sed 's/\/dev\///')"
+	local SHDD="${HDD//\/dev\/}"
 
-	dialog \
-	--colors \
-	--title "[ Festplatten Partitionierung ]" \
-	--backtitle "${TITLE}" \
-	--ok-label "Weiter" \
-	--msgbox "\nBitte legen Sie 3 Partitionen an.\n\n\
-		[ \Z3${SHDD}1\Zn ] Typ: \Z3Linux\Zn mit ca. 50MB\n\
-		[ \Z3${SHDD}2\Zn ] Typ: \Z3Linux Swap\Zn mit ca. 256MB\n\
-		[ \Z3${SHDD}3\Zn ] Typ: \Z3Linux \Zn mit dem Rest (min. 256MB)\n\n\
-		Bitte ${SHDD}1 als \Z3bootable\Zn markieren." 12 81
-}
-
-dialog_setup_hdd_info_flash()
-{
-	local SHDD="$(echo $HDD | sed 's/\/dev\///')"
-
-	dialog \
-	--colors \
-	--title "[ Festplatten Partitionierung ]" \
-	--backtitle "${TITLE}" \
-	--ok-label "Weiter" \
-	--msgbox "\nBitte legen Sie 1 Partition an.\n\n\
-		[ \Z3${SHDD}1\Zn ] Typ: \Z3Linux\Zn mit dem gesamten Speicher\n\
-		Bitte ${SHDD}1 als \Z3bootable\Zn markieren." 12 81
+	messagebox -h $"[ Harddrive partitioning ]" \
+		$"\nPlease create 1 partition.\n\n\[ \Z3${SHDD}1\Zn ] type: \Z3linux\Zn with the whole diskspace\n\Please mark ${SHDD}1 \Z3bootable\Zn."
 }
 
 dialog_setup_hdd_info_auto()
 {
-	local SHDD="$(echo $HDD | sed 's/\/dev\///')"
+	local SHDD="${HDD//\/dev\/}"
 
-	dialog \
-	--colors \
-	--title "[ Festplatten Partitionierung ]" \
-	--backtitle "${TITLE}" \
-	--ok-label "Weiter" \
-	--msgbox "\nAchtung!\n\
-		Alle Daten werden von der Disk [ \Z3${HDD}\Zn ] gelöscht!" 12 81
+	messagebox -h $"[ Harddrive partitioning ]" \
+		$"\Z1Warning!\Zn\n\nAll data on disk [ \Z3${HDD}\Zn ] will be erased!"
 }
 
 dialog_setup_system_menu()
 {
-	local i
+	local mode
+	local retval
 
-	i=$(dialog \
+	mode=$(dialog \
 	--backtitle "${TITLE}" \
 	--title "[ Festplatten Partitionierung ]" \
 	--cancel-label "Abbrechen" \
@@ -161,15 +139,13 @@
 	"" "" \
 	"" "\Z1Experten Modi:\Zn" \
 	"2" "Normale IDE-Disk (Manuell)" \
-	"3" "Flash-Speicher (Manuell)")
-	RES=$?
-	[[ ${RES} -eq 1 ]] && return 1
-	if [[ ${RES} -eq 0 ]]
+	retval=$?
+	[[ ${retval} -eq 1 ]] && return 1
+	if [[ ${retval} -eq 0 ]]
 	then
 		case "${i}" in
 			"1") run_install_auto ;;
 			"2") run_install_normal ;;
-			"3") run_install_flash ;;
 			"") dialog_setup_system_menu;;
 		esac
 	fi
@@ -180,7 +156,7 @@
 	local i
 	local hwtmp
 
-	if [ -x $(which mktemp &> /dev/null) ]
+	if [ -x $(type -P mktemp) ]
 	then
 		hwtmp="$(mktemp)"
 	else
@@ -277,44 +253,6 @@
 	fi
 }
 
-dialog_setup_hdd_partitions_manuell_flash()
-{
-	local i
-
-	if [[ -z ${installdevs} ]]
-	then
-		dialog \
-		--backtitle "${TITLE}" \
-		--ok-label "Beenden" \
-		--msgbox "Kein geeignetes Laufwerk gefunden.\nDie Installation ist fehlgeschlagen." 6 70
-		exit 1
-	else
-
-		echo "dialog \\" > /tmp/hddtmp.sh
-		echo "--backtitle \"${TITLE}\" \\" >> /tmp/hddtmp.sh
-		echo "--ok-label \"Weiter\" \\" >> /tmp/hddtmp.sh
-		echo "--cancel-label \"Beenden\" \\" >> /tmp/hddtmp.sh
-		echo "--stdout \\" >> /tmp/hddtmp.sh
-		echo "--menu \"Installations Laufwerk auswaehlen:\" 10 70 3 \\" >> /tmp/hddtmp.sh
-
-		for i in ${installdevs}
-		do
-			echo "\"${i}\" \"\" \\" >> /tmp/hddtmp.sh
-		done
-		echo -e "\n" >> /tmp/hddtmp.sh
-
-		chmod a+x /tmp/hddtmp.sh
-		HDD="$(/tmp/hddtmp.sh)"
-		RES=$?
-		[[ ${RES} -eq 1 ]] && return 1
-		if [[ ${RES} -eq 0 ]]
-		then
-			dialog_setup_hdd_info_flash
-			setup_hdd_partitions_manuell_flash
-		fi
-	fi
-}
-
 dialog_setup_hdd_partitions_auto()
 {
 	local i
@@ -608,16 +546,6 @@
 
 setup_hdd_partitions_manuell()
 {
-	BOOTHDD="${HDD}1"
-	SWAPHDD="${HDD}2"
-	ROOTHDD="${HDD}3"
-
-	## hdds partitionieren manuell
-	cfdisk ${HDD} || dialog_die
-}
-
-setup_hdd_partitions_manuell_flash()
-{
 	ROOTHDD="${HDD}1"
 
 	## hdds partitionieren manuell
@@ -626,27 +554,11 @@
 
 setup_hdd_format()
 {
-	mkswap ${SWAPHDD} || dialog_die
-	mke2fs -j -q ${BOOTHDD} || dialog_die
-	mke2fs -j -q ${ROOTHDD} || dialog_die
-}
-
-setup_hdd_format_flash()
-{
 	mke2fs -j -q ${ROOTHDD} || dialog_die
 }
 
 install_mount_rootfs()
 {
-	swapon ${SWAPHDD} || dialog_die
-	mount ${ROOTHDD} ${INSTALLROOT} || dialog_die
-	install -d ${INSTALLROOT}/boot || dialog_die
-	mount ${BOOTHDD} ${INSTALLROOT}/boot || dialog_die
-	cd ${INSTALLROOT} || dialog_die
-}
-
-install_mount_rootfs_flash()
-{
 	mount ${ROOTHDD} ${INSTALLROOT} || dialog_die
 	install -d ${INSTALLROOT}/boot || dialog_die
 	cd ${INSTALLROOT} || dialog_die
@@ -831,7 +743,7 @@
 
 is_uuid_supported()
 {
-	if [[ -x $(which busybox.mkinitrd &> /dev/null) ]]
+	if [[ -x $(type -P busybox.mkinitrd) ]]
 	then
 		# only detect uuids if supported
 		if [[ ! -z $(busybox.mkinitrd | grep blkid) ]]
@@ -867,10 +779,8 @@
 	# schreibe fstab
 	if is_uuid_supported
 	then
-		echo -e "UUID=$(get_uuid ${BOOTHDD})\t/boot\t${FORMAT_FILESYSTEM}\tnoatime,noauto\t1 1" > ${INSTALLROOT}/etc/fstab || dialog_die
 		echo -e "UUID=$(get_uuid ${ROOTHDD})\t/\t${FORMAT_FILESYSTEM}\tnoatime\t0 0" >> ${INSTALLROOT}/etc/fstab || dialog_die
 	else
-		echo -e "${BOOTHDD}\t/boot\t${FORMAT_FILESYSTEM}\tnoatime,noauto\t1 1" > ${INSTALLROOT}/etc/fstab || dialog_die
 		echo -e "${ROOTHDD}\t/\t${FORMAT_FILESYSTEM}\tnoatime\t0 0" >> ${INSTALLROOT}/etc/fstab || dialog_die
 	fi
 	# not needed busybox loads all with swapon -a, even if not mentioned in fstab
@@ -895,31 +805,11 @@
 	fi
 }
 
-install_system_settings_flash()
-{
-	# schreibe fstab
-	if is_uuid_supported
-	then
-		echo -e "UUID=$(get_uuid ${ROOTHDD})\t/\t${FORMAT_FILESYSTEM}\tnoatime\t0 0" > ${INSTALLROOT}/etc/fstab || dialog_die
-	else
-		echo -e "${ROOTHDD}\t/\t${FORMAT_FILESYSTEM}\tnoatime\t0 0" > ${INSTALLROOT}/etc/fstab || dialog_die
-	fi
-	echo -e "proc\t/proc\tproc\tdefaults\t0 0" >> ${INSTALLROOT}/etc/fstab || dialog_die
-	echo -e "shm\t/dev/shm\ttmpfs\tdefaults\t0 0" >> ${INSTALLROOT}/etc/fstab || dialog_die
-}
-
 install_umount_rootfs()
 {
 	cd /
 	umount ${INSTALLROOT}/boot || dialog_die
 	umount ${INSTALLROOT} || dialog_die
-	swapoff ${SWAPHDD} || dialog_die
-}
-
-install_umount_rootfs_flash()
-{
-	cd /
-	umount ${INSTALLROOT} || dialog_die
 }
 
 install_do_reboot()
@@ -953,50 +843,31 @@
 	dialog_install_successful
 }
 
-run_install_flash()
-{
-	dialog_hardware_detection
-
-	dialog_setup_hdd_partitions_manuell_flash
-	dialog_setup_hdd_format
-	setup_hdd_format_flash > /dev/null
-	install_mount_rootfs_flash
-	(install_system_image > /tmp/install.log) 2> /tmp/install_errors.log | dialog_install_meter | dialog_install_system_image
-
-	dialog_install_settings
-	sleep 1
-	install_system_settings_flash
-	install_initrd_chroot
-
-	dialog_install_bootsector
-	install_bootsector_chroot
-
-	install_umount_rootfs_flash
-	dialog_install_successful
-}
-
 run_install_auto()
 {
 	dialog_hardware_detection
 
 	dialog_setup_hdd_partitions_auto
 	dialog_setup_hdd_format
-	setup_hdd_format_flash > /dev/null
-	install_mount_rootfs_flash
+	setup_hdd_format > /dev/null
+	install_mount_rootfs
 	(install_system_image > /tmp/install.log) 2> /tmp/install_errors.log | dialog_install_meter | dialog_install_system_image
 
 	dialog_install_settings
 	sleep 1
-	install_system_settings_flash
+	install_system_settings
 	install_initrd_chroot
 
 	dialog_install_bootsector
 	install_bootsector_chroot
 
-	install_umount_rootfs_flash
+	install_umount_rootfs
 	dialog_install_successful
 }
 
+# set some proper traps
+trap "trap_exit" SIGINT SIGQUIT
+
 dialog_main
 
 exit 0