Annotation of /trunk/glib2/patches/glib-2.34-revert-warn-glib-compile-schemas.patch
Parent Directory | Revision Log
Revision 2030 -
(hide annotations)
(download)
Mon Jan 21 13:20:30 2013 UTC (11 years, 8 months ago) by niro
File size: 1375 byte(s)
Mon Jan 21 13:20:30 2013 UTC (11 years, 8 months ago) by niro
File size: 1375 byte(s)
-added patch to shut up warnings
1 | niro | 2030 | From 6560b37450cd19c4a7c7b690e279fe97b7bfdcaa Mon Sep 17 00:00:00 2001 |
2 | From: Ryan Lortie <desrt@desrt.ca> | ||
3 | Date: Thu, 12 Apr 2012 23:55:34 +0000 | ||
4 | Subject: glib-compile-schemas: warn about bad dconf paths | ||
5 | |||
6 | For quite some time the recommended usage of GSettings and dconf has | ||
7 | been to use paths like /org/gnome/example/. Use of /apps/ has spilled | ||
8 | over from GConf and is continuing to make its way into a number of | ||
9 | applications as they port. | ||
10 | |||
11 | glib-compile-schemas will now warn about these types of paths being | ||
12 | used. This generates a lot of noise, but hopefully it will reduce the | ||
13 | number of ported applications making this mistake. | ||
14 | --- | ||
15 | diff --git a/gio/glib-compile-schemas.c b/gio/glib-compile-schemas.c | ||
16 | index cf02389..27d0181 100644 | ||
17 | --- a/gio/glib-compile-schemas.c | ||
18 | +++ b/gio/glib-compile-schemas.c | ||
19 | @@ -1204,6 +1204,12 @@ parse_state_start_schema (ParseState *state, | ||
20 | return; | ||
21 | } | ||
22 | |||
23 | + if (path && (g_str_has_prefix (path, "/apps/") || | ||
24 | + g_str_has_prefix (path, "/desktop/") || | ||
25 | + g_str_has_prefix (path, "/system/"))) | ||
26 | + g_printerr ("warning: Schema '%s' has path '%s'. Paths starting with " | ||
27 | + "'/apps/', '/desktop/' or '/system/' are deprecated.\n", id, path); | ||
28 | + | ||
29 | state->schema_state = schema_state_new (path, gettext_domain, | ||
30 | extends, extends_name, list_of); | ||
31 | |||
32 | -- | ||
33 | cgit v0.9.0.2 |