xorg-old/patches-6.8.2-r10/9235_all_xorg-x11-6.7.0-libxf86config-monitor-freq-fix.patch

Patch by Mike A. Harris <mharris@redhat.com>

Fix bug http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=120950 and the
200,000,000 bug duplicates.  ;o)


--- a/xc/programs/Xserver/hw/xfree86/parser/Monitor.c.libxf86config-do-not-comment-out-monitor-frequencies	Fri May  7 04:12:31 2004
+++ b/xc/programs/Xserver/hw/xfree86/parser/Monitor.c	Fri May  7 04:21:31 2004
@@ -671,17 +671,44 @@
 			fprintf (cf, "\tDisplaySize  %d\t%d\n",
 					 ptr->mon_width,
 					 ptr->mon_height);
+/* This causes the config file to always be written out with the
+ * HorizSync/VertRefresh lines commented out, forcing all default X config
+ * files written out by this library to rely on DDC.  This is not a viable
+ * thing to do because there are a great number of reasons why DDC may not
+ * be useable, such as:
+ * - KVM's which do not pass DDC
+ * - Video drivers with no DDC support
+ * - DFPs, LCDs, and to a lesser extent nowadays CRTs which do not support
+ *   DDC
+ * - Other hardware plugged into the monitor cable which interferes with DDC
+ * - Non-x86 architecture which the DDC probing code of a driver uses the
+ *   video BIOS, but which that does not work.
+ * - various other scenarios
+ *
+ * Red Hat bugzilla is loaded with bugs reported from savage, radeon, nv,
+ * r128, and other hardware users in which this problem causes them to have
+ * seriously limited display resolutions because the monitor frequencies are
+ * not known when X starts up, forcing them into 640x480.  As such, I'm
+ * changing this back to the way it used to be under the "if it wasn't broken,
+ * don't fix it" principle.  I doubt we will every be able to 100% rely that
+ * DDC will always be available, so this will never be a reliable way to
+ * configure monitors.
+ *
+ * Mike A. Harris <mharris@redhat.com>, May 7, 2004 (X.org X11 6.7.0)
+ */
+#if 0
 		if ( ptr->mon_n_hsync || ptr->mon_n_vrefresh )
 		    fprintf(cf," ### Uncomment if you don't want to default to DDC:\n");
+#endif
 		for (i = 0; i < ptr->mon_n_hsync; i++)
 		{
-			fprintf (cf, "#\tHorizSync    %2.1f - %2.1f\n",
+			fprintf (cf, "\tHorizSync    %2.1f - %2.1f\n",
 					 ptr->mon_hsync[i].lo,
 					 ptr->mon_hsync[i].hi);
 		}
 		for (i = 0; i < ptr->mon_n_vrefresh; i++)
 		{
-			fprintf (cf, "#\tVertRefresh  %2.1f - %2.1f\n",
+			fprintf (cf, "\tVertRefresh  %2.1f - %2.1f\n",
 					 ptr->mon_vrefresh[i].lo,
 					 ptr->mon_vrefresh[i].hi);
 		}
1	niro	167	Patch by Mike A. Harris <mharris@redhat.com>
2
3			Fix bug http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=120950 and the
4			200,000,000 bug duplicates. ;o)
5
6
7			--- a/xc/programs/Xserver/hw/xfree86/parser/Monitor.c.libxf86config-do-not-comment-out-monitor-frequencies Fri May 7 04:12:31 2004
8			+++ b/xc/programs/Xserver/hw/xfree86/parser/Monitor.c Fri May 7 04:21:31 2004
9			@@ -671,17 +671,44 @@
10			fprintf (cf, "\tDisplaySize %d\t%d\n",
11			ptr->mon_width,
12			ptr->mon_height);
13			+/* This causes the config file to always be written out with the
14			+ * HorizSync/VertRefresh lines commented out, forcing all default X config
15			+ * files written out by this library to rely on DDC. This is not a viable
16			+ * thing to do because there are a great number of reasons why DDC may not
17			+ * be useable, such as:
18			+ * - KVM's which do not pass DDC
19			+ * - Video drivers with no DDC support
20			+ * - DFPs, LCDs, and to a lesser extent nowadays CRTs which do not support
21			+ * DDC
22			+ * - Other hardware plugged into the monitor cable which interferes with DDC
23			+ * - Non-x86 architecture which the DDC probing code of a driver uses the
24			+ * video BIOS, but which that does not work.
25			+ * - various other scenarios
26			+ *
27			+ * Red Hat bugzilla is loaded with bugs reported from savage, radeon, nv,
28			+ * r128, and other hardware users in which this problem causes them to have
29			+ * seriously limited display resolutions because the monitor frequencies are
30			+ * not known when X starts up, forcing them into 640x480. As such, I'm
31			+ * changing this back to the way it used to be under the "if it wasn't broken,
32			+ * don't fix it" principle. I doubt we will every be able to 100% rely that
33			+ * DDC will always be available, so this will never be a reliable way to
34			+ * configure monitors.
35			+ *
36			+ * Mike A. Harris <mharris@redhat.com>, May 7, 2004 (X.org X11 6.7.0)
37			+ */
38			+#if 0
39			if ( ptr->mon_n_hsync \|\| ptr->mon_n_vrefresh )
40			fprintf(cf," ### Uncomment if you don't want to default to DDC:\n");
41			+#endif
42			for (i = 0; i < ptr->mon_n_hsync; i++)
43			{
44			- fprintf (cf, "#\tHorizSync %2.1f - %2.1f\n",
45			+ fprintf (cf, "\tHorizSync %2.1f - %2.1f\n",
46			ptr->mon_hsync[i].lo,
47			ptr->mon_hsync[i].hi);
48			}
49			for (i = 0; i < ptr->mon_n_vrefresh; i++)
50			{
51			- fprintf (cf, "#\tVertRefresh %2.1f - %2.1f\n",
52			+ fprintf (cf, "\tVertRefresh %2.1f - %2.1f\n",
53			ptr->mon_vrefresh[i].lo,
54			ptr->mon_vrefresh[i].hi);
55			}